Add openfasoc-tapeouts as git submodule #102
Conversation
1. Move tapeouts/ folder to openfasoc-tapeouts repo 2. Add openfasoc-tapeouts repo as submodule
|
Part 2 to address the issue is this PR: idea-fasoc/openfasoc-tapeouts#1 |
There was a problem hiding this comment.
In the readme of the sub repo, I suggest further adding brief descriptions and links to the individual tapeout pages (like "temperature sensor in SkyWater 130nm -> link"). For now there is only one tapeout and testing documented and we can add those for this single one.
There was a problem hiding this comment.
@luccareinehr Do you think we should add some dedicated section to give an overview of the testing? I think its a good idea. Also try to enable the same sphinx docs on the sub repo idea-fasoc/openfasoc-tapeouts#2
|
@saicharan0112 @msaligane Should we put the documentation for testing in the the same docs as OpenFASOC (https://openfasoc.readthedocs.io) or create a new readthedocs for the openfasoc-tapeouts repo? |
|
@luccareinehr I think it should be in the same doc. |
|
@saicharan0112 do you approve these changes? |
|
He didn't add a dedicated section in the same openfasoc docs yet, @msaligane . Can we wait for @luccareinehr to do that? |
|
I added a Tapeouts section in PR #100, it's easier to change it there because of the other files that had to be updated (adding the Tapeouts entry in index.rst, for example). This page will embed the README file from openfasoc-tapeouts after idea-fasoc/openfasoc-tapeouts#3 gets merged (take a look at the source here). It should look like this once everything is merged:
|
|
@luccareinehr Thanks! Can you resolve the merge issues? |
|
@msaligane this is already implemented by @luccareinehr in the #100. This PR can be closed. |
|
@saicharan0112 Not all of it, this PR also adds openfasoc-tapeouts as a git submodule, so we don't have to clone it everytime I'll update the pull request to reflect the changes |
|
All ready now |
|
Thanks @luccareinehr ! |
Part 1 to address #70