Add Glayout checks in CI #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alibillalhammoud @andylithia can you help out with a review? |
|
@msaligane all checks have been added, but this shouldn't be merged until gf180 is added to docker image (required for gf180 drc run) |
… build a new image
alibillalhammoud
suggested changes
May 9, 2024
| patterns = [pattern_diff, pattern_nmos, pattern_pmos, pattern_opamp] | ||
| replacements = ['diff_test', 'nmos_test', 'pmos_test', 'opamp_test'] | ||
|
|
||
| for i, pattern in enumerate(patterns): |
There was a problem hiding this comment.
do list comprehension here
| cellname delete ldoInst | ||
| cellname rename ldoInst_flat ldoInst | ||
| flatten diff_test_flat | ||
| load diff_test_flat |
There was a problem hiding this comment.
Make the first thing LDO, may break the generators
| #the path for your cdl/ngspice file | ||
| CDL_FILE_PATH = /home/elonjia/Desktop/tool_package/ALIGN-public/work/DCDC_MUX/DCDC_MUX.sp | ||
| CDL_FILE_PATH = /home/chetanya/OpenFASOC/openfasoc/common/platforms/sky130hd/cdl/sky130_fd_sc_hd.spice |
There was a problem hiding this comment.
dont hardcode paths
| @@ -790,7 +790,7 @@ | |||
| }, | |||
| "language_info": { | |||
| "name": "python", | |||
| "version": "3.9.13" | |||
| "version": "3.8.10" | |||
There was a problem hiding this comment.
current notebook is known to work
|
this should not be merged yet, many changes need to be made |
|
closing this PR, need to adapt to glayout changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to enable CI checking for glayout. The vision is to enable DRC and LVS checks for the primitives and the components marked with the
@celldecorator inglayout/components. This envolves the following changes:.ymlfile for GitHub actions