Glayout LLM + Docs + Notebooks #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test cases
added parameters/fixed routes
| @@ -0,0 +1,4 @@ | |||
| # Common Drain Amplifier | |||
| The purpose of a common drain amplifier, aka a source follower, is to provide buffering. It has high input impedance, low output impedance, and a voltage gain close to unity. | |||
There was a problem hiding this comment.
maybe provide a separate example of a source follower being used in buffering. The LLM might place just a common drain stage as a buffer, which isn't the most ideal
| @@ -0,0 +1,12 @@ | |||
| # Current Mirror | |||
| A current mirror is a circuit designed to copy a current | |||
There was a problem hiding this comment.
designed to copy a current
copy or boost a current
| @@ -0,0 +1,3 @@ | |||
| # Strong Arm Latch | |||
| A strong arm latch is a comparator (which means it compares two input voltages). If one voltage is higher it outputs a high voltage and if one of them is lower then it output a low voltage. | |||
There was a problem hiding this comment.
this doesn't really make sense, might cause training problems
Comment on lines
+3
to
+4
| The pmos is above the nmos and it's source is tied to vdd. The nmos source is tied to ground. The nmos drain and pmos drain are routed together. The node connecting the nmos and pmos drain is the output node. Additonally, the nmos gate and pmos gate are connected. The node connecting the nmos and pmos gate is the input node. |
There was a problem hiding this comment.
can merge these two lines
chetanyagoyal
approved these changes
Jun 5, 2024
msaligane
requested changes
Jun 5, 2024
There was a problem hiding this comment.
@alibillalhammoud @chetanyagoyal We want these convos to be in the llm folder?
msaligane
reviewed
Jun 5, 2024
| @@ -3,7 +3,7 @@ | |||
| # Apache License | |||
There was a problem hiding this comment.
Should we have a header with a little more details?
msaligane
approved these changes
Jun 5, 2024
|
Please add my comments as issues to fix later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glayout LLM v1
We are getting decent results with the 7b model. It is highly versatile on 2-4 transistor circuits. Current model config: