Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glayout Restructure #307

Closed
wants to merge 28 commits into from
Closed

Glayout Restructure #307

wants to merge 28 commits into from

Conversation

chetanyagoyal
Copy link
Collaborator

@chetanyagoyal chetanyagoyal commented Jun 5, 2024 •
edited
Loading

Implements the following folder structure

  • glayout/flow

    • primitives
      • fet.py
      • mimcap.py
      • guardring.py
      • resistor.py
      • via_gen.py
    • blocks
      • diff_pair
        • diff_pair.py
        • init.py
        • spice netlist
      • opamp
        • ...
      • ...other larger blocks
    • regression
      • drc
        • ...drc report folders
      • lvs
        • ...lvs report folders
      • testbenches
        • ...component spice testbench results
    • pdk
    • spice
    • placement (contains placement methods)
    • routing

  • the idea for the empty regression folder is to store drc, lvs and spice testbench reports there

  • the drc and lvs functions have been adapted so that

    • they create a folder named {design_name} in the respective drc, lvs or testbench folder
    • store the report file in that folder

chetanyagoyal and others added 26 commits May 25, 2024 12:16
@chetanyagoyal
1. correct opamp netlist (mimcap pin order reversed in gain stage)
8635b41 
2. swap plus and minus pins in add pin labels function for opamp
3. modify error logging in drc and lvs for glayout
4. create yaml workflow file for glayout
5. add pip install glayout from git commands for later use
@chetanyagoyal
add all commands to same environment
37654ef
@chetanyagoyal
fix: reduce image container size by only downloading required packages
6bec5b5
@chetanyagoyal
push changes to cells, lvs working
4d7358d
@chetanyagoyal
update workflow file to use stable image
a9729fc
@chetanyagoyal
Delete openfasoc/generators/glayout/test_glayout.py
bda92c1 
delete unimportant copy of glayout parser script in generators/glayout folder (is copied from .github/scripts)
@chetanyagoyal
1. add new netlist for current mirror
988727a 
2. regression test for current mirror
3. cap off drc lvs for components
@chetanyagoyal
Merge branch 'main' of https://github.com/chetanya-goyal/OpenFASOC_ci …
d988727 
…into main
@chetanyagoyal
add current mirror to ci
0a86468
@chetanyagoyal
modify magic extraction and add blackbox arg to lvs call
a701be0
@chetanyagoyal
switch to node20
8240212
@chetanyagoyal
change all to node20
af9ed70
@chetanyagoyal
change all to node20
e878645
new_files
146048b
new_files
3d00e9f
enable spice testbench for opamp
cfdc93e
enable spice testbench for opamp, fix import errors
7b90a1f
enable spice testbench for opamp, fix import errors
c631f2d
separate opamp testbench
491d458
@chetanyagoyal
Merge pull request #1 from chetanya-goyal/testbench
af4e48f 
Testbench
@chetanyagoyal
Merge pull request #1 from chetanya-goyal/main
035b29a 
quick update
@chetanyagoyal
Merge pull request #2 from chetanya-goyal/main
02bafc1 
merge test
create dirs
37efb26
@chetanyagoyal
Merge branch 'idea-fasoc:main' into main
c79c401
update imports
3139f65
commit regression directory
8f9acb0
@chetanyagoyal
Copy link
Collaborator Author

[IMPORTANT]: @msaligane the branch 'no_top_components' of the source repo has another tentative folder structure, which might be a better idea

@chetanyagoyal
Copy link
Collaborator Author

@msaligane @alibillalhammoud , the conflicts have been resolved as best they can, but github won't recognise it due the folder changes

@chetanyagoyal chetanyagoyal mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alibillalhammoud alibillalhammoud Awaiting requested review from alibillalhammoud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chetanyagoyal