Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes for PR 333 #336

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Quick fixes for PR 333 #336

merged 2 commits into from
Sep 18, 2024

Conversation

chetanyagoyal
Copy link
Collaborator

No description provided.

@chetanyagoyal
Copy link
Collaborator Author

@msaligane this can be merged. We need to commit these changes to sort out ali's PRs conflicts

@alibillalhammoud
Copy link
Collaborator

These are the correct changes. Can you merge this so that we can merge the other PR as well?

Copy link
Collaborator

@alibillalhammoud alibillalhammoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

@msaligane msaligane merged commit f010202 into idea-fasoc:main Sep 18, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants