Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flipped VOltage Follower Pcell, Analog vibes, Chipathon 2024 #352

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Flipped VOltage Follower Pcell, Analog vibes, Chipathon 2024 #352

wants to merge 25 commits into from

Conversation

Subhampal9
Copy link

  1. DRC and LVS clean reports are attached
  2. README is updated
  3. fvf.py is annotated with comments

@Subhampal9
added FVF Pcell files, Analog Vibes, Chipathon 2024
309241d 
1. drc and lvs reports are also attached
2. sample picture of gds is attached
3.  README file and annotations in fvf.py are added
@Subhampal9
Updated README.md
29af8ab
@Subhampal9
Updated comments
51bb493
@Subhampal9
Merge pull request #1 from Subhampal9/Subhampal9-FVF
1ac1802 
added FVF Pcell files, Analog Vibes, Chipathon 2024
alibillalhammoud
alibillalhammoud approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@alibillalhammoud alibillalhammoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but if you want to for the future you may consider add labels using the MappedPDK (see slack discussion). We would need to do that as a separate PR, but this looks good

@Subhampal9
Copy link
Author

Subhampal9 commented Nov 28, 2024 •
edited
Loading

Ok I will check and try to do that.
Can you provide the link of the converstation.

harshkhandeparkar
harshkhandeparkar reviewed Dec 12, 2024
View reviewed changes
openfasoc/generators/glayout/glayout/flow/blocks/elementary/FVF/fvf.py Outdated
top_level = Component(name="flipped_voltage_follower")

#two fets
if device_type == "nmos":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code duplication can be reduced here since only the function name changes and not the arguments.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I am uploading the new file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshkhandeparkar harshkhandeparkar harshkhandeparkar left review comments

@alibillalhammoud alibillalhammoud alibillalhammoud approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Subhampal9 @harshkhandeparkar @alibillalhammoud