Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build failed if support win7 #369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

re2zero
Copy link

@re2zero re2zero commented Aug 27, 2024

If add define -D_WIN32_WINNT=0x0601 in roder to support run on win7, it miss htnoll and nthll functions, exclude them if support win7.

Log: Fix build issue if support win7.

Copy link
Owner

@idealvin idealvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要手写一个 win7 以下版本的实现

If add define -D_WIN32_WINNT=0x0601 in roder to support run on win7, it
miss htnoll and nthll functions, exclude them if support win7.

Log: Fix build issue if support win7.
@re2zero
Copy link
Author

re2zero commented Sep 10, 2024

参考一个官方
https://learn.microsoft.com/zh-cn/cpp/c-runtime-library/reference/byteswap-uint64-byteswap-ulong-byteswap-ushort?view=msvc-170
并用测试代码验证两个版本(win7 和win10)结果一致。

@re2zero
Copy link
Author

re2zero commented Sep 19, 2024

需要手写一个 win7 以下版本的实现

已参考官方写了一个,康康

@re2zero re2zero requested a review from idealvin October 9, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants