Extend Transifex developer notes for label and name about locationSet.include countries
#93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.include` countries Co-Authored-By: Martin Raifer <martin@raifer.tech>
tordans
force-pushed
the
dev-notes-locationset
branch
from
953a16b
to
b571567
Compare
|
FYI I created openstreetmap/id-tagging-schema#825 as a follow up for this to explain how this new feature can be used. |
tyrasd
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, it becomes easier for translators to skip local presets. It adds notes on local presets to the Transifex developer notes.
It is based on the field
locationSet: ['de']which exists for fields and presets. However, we only look atlocationSet.includesfor those notes. We skiplocationSet.excludesbecause that would suggest that a translation is not needed, which can be wrong in cases, where the keys are reused / referenced in another preset. The translation is only done once but have multiple references with differentlocationSets.Related
isced:levelopenstreetmap/id-tagging-schema#331 (comment)Closes #27