Fixed test after debian-stable is bookworm #315
Conversation
* updated mongo to 7.0, repo mongo contains only 7.0 for debian bookworm * installed redis 6.*, redis 7.* is not supported by `go-redis/redis/v8`
| @@ -0,0 +1 @@ | |||
| .github | |||
There was a problem hiding this comment.
This is a small optimization for local testing. I can exclude it from the PR if necessary. On line 63 in Dockerfile.runtest, we have COPY ./ ./, which copies all files. This just excludes it from the Docker context and doesn’t copy this folder to the image at this step. This means that if I change something in the .github folder, it won’t invalidate all Docker layers after COPY ./ ./.
There was a problem hiding this comment.
Gotcha, I was just wondering if ignoring .github, where workflows are declared, has anything to do with workflows no longer running.
@iegomez Did you mean why it is running, e.g., on this PR? I suppose that’s because the test.yml pipeline contains the trigger |
|
@mbv nope, I really meant they're not running when they normally did. Now only CodeQL checks are running and nothing else, so I fetched and checked out the PR's branch to run tests locally. It's still building the image right now. Edit: it finished building and the tests are passing, but I still wonder why workflows stopped. |
|
See the examples: Here is your PR #307, when the branch is in your repo and not a fork, the tests are triggered: Here is a PR from a fork #285, and only CodeQL is triggered. 
The difference lies in the triggers for the pipelines: CodeQL contains both push triggers (for branches in this repo) and pull_request triggers (for any branches). 
Added: For my branch, it has been run in the fork: https://github.com/mbv/mosquitto-go-auth/actions/runs/7861405724 |
|
@mbv sorry, I misunderstood, you're completely right. Haven't worked on this for a long while and I'm a bit rusty. |
go-redis/redis/v8