Fixes for website migration #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
didn't this code move already ? |
|
Well, these commits actually remove the moved files from the specification repository. "Fixes…" was probably not the best name :) |
Without a title attribute in each file's front-matter Jekyll will use the global title configured in the site as the page title. However, this means that building the combined .md requires removing the whole front-matter (all lines between and including the "---" ones), not just the "---" ones.
|
I'll push more changes onto this branch from time to time as I progress through the migration; probably rebase when necessary, too. No need to merge soon. |
Also updates a couple of links to other external sites. This also removes dead links (which had been dead before the CMS migration, too).
kramdown (used by Jekyll) only recognizes a table when there's a blank line following, even if the table is at the very end of the file. This is likely a bug, but let's just work around it.
|
The required changes are mostly complete now. I'll merge in a week or so if no one objects. |
retokromer
approved these changes
May 29, 2020
robUx4
reviewed
Jun 1, 2020
robUx4
reviewed
Jun 1, 2020
robUx4
reviewed
Jun 1, 2020
retokromer
reviewed
Jun 1, 2020
mbunkus
force-pushed
the
fixes-for-website-migration
branch
from
90b268c to
e8f9e8e
Compare
mbunkus
force-pushed
the
fixes-for-website-migration
branch
from
e8f9e8e to
a1c5d4d
Compare
|
Soooo… all of the objections have been addressed as far as I can tell. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various modifications that target splitting off pure website related stuff into its own repository.