Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linker error tbb #265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Linker error tbb #265

wants to merge 3 commits into from

Conversation

gdamiand
Copy link

Solve the linker error.

  1. Link with tbb
  2. Disable Qt keywords to solve a name clash with tbb

solve issue #259

Osyotr
Osyotr reviewed Jan 17, 2024
View reviewed changes
IfcPlusPlus/CMakeLists.txt Outdated Show resolved Hide resolved
@ifcquery
Copy link
Owner

Hi, thanks for the pull request.
I cannot merge anything, because it messes up and partly invalidates the license.
If you agree, I can copy the two lines into the Cmake file, and publish from my account under the current license?

@Osyotr
Copy link

Osyotr commented Jan 18, 2024

I cannot merge anything, because it messes up and partly invalidates the license.

Consider adding CLA https://github.com/cla-assistant/cla-assistant.

@gdamiand
Copy link
Author

Hi, thanks for the pull request. I cannot merge anything, because it messes up and partly invalidates the license. If you agree, I can copy the two lines into the Cmake file, and publish from my account under the current license?

Sure ! go ahead. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Osyotr Osyotr Osyotr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdamiand @ifcquery @Osyotr