Skip to content

Commit

Permalink
GITechDemo:
Browse files Browse the repository at this point in the history
* tuned some parameters, particularly for tonemapping
* fixed a couple of memory leaks
  • Loading branch information
iftodebogdan committed Jan 21, 2022
1 parent 2068a18 commit eae46f4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 8 deletions.
1 change: 1 addition & 0 deletions GITechDemo/Code/AppMain/GITechDemo/GITechDemo.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ void GITechDemo::Release()

bExtraResInit = false;

ImGui::Shutdown();
RenderScheme::ReleaseResources();

RenderResource::FreeAll();
Expand Down
16 changes: 8 additions & 8 deletions GITechDemo/Code/AppMain/GITechDemo/Resources/AppResources.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -777,7 +777,7 @@ namespace GITechDemoApp
"Directional light",
RenderConfig::DirectionalLight::IrradianceFactor,
0.1f,
1.f);
0.5f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Reflection factor",
Expand Down Expand Up @@ -1048,7 +1048,7 @@ namespace GITechDemoApp
"Reflective shadow map",
RenderConfig::ReflectiveShadowMap::KernelScale,
0.001f,
0.025f);
0.02f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Upscale threshold",
Expand Down Expand Up @@ -1617,47 +1617,47 @@ namespace GITechDemoApp
"HDR tone mapping",
RenderConfig::PostProcessing::ToneMapping::ShoulderStrength,
0.1f,
0.5f);
0.15f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Linear strength",
"Strength of the linear part of the filmic tone mapping curve",
"HDR tone mapping",
RenderConfig::PostProcessing::ToneMapping::LinearStrength,
0.1f,
0.58f);
0.5f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Linear angle",
"Angle of the linear part of the filmic tone mapping curve",
"HDR tone mapping",
RenderConfig::PostProcessing::ToneMapping::LinearAngle,
0.1f,
0.35f);
0.1f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Toe strength",
"Strength of the toe part of the filmic tone mapping curve",
"HDR tone mapping",
RenderConfig::PostProcessing::ToneMapping::ToeStrength,
0.1f,
0.48f);
0.2f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Toe numerator",
"Numerator of the toe part of the filmic tone mapping curve",
"HDR tone mapping",
RenderConfig::PostProcessing::ToneMapping::ToeNumerator,
0.01f,
0.12f);
0.02f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Toe denominator",
"Denominator of the toe part of the filmic tone mapping curve",
"HDR tone mapping",
RenderConfig::PostProcessing::ToneMapping::ToeDenominator,
0.1f,
0.58f);
0.3f);

CREATE_ARTIST_PARAMETER_OBJECT(
"Linear white",
Expand Down
4 changes: 4 additions & 0 deletions GITechDemo/Code/AppMain/GITechDemo/Utilities/Poisson.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ std::vector<sPoint> GeneratePoissonPoints( float MinDist, int NewPointsCount, si

//std::cout << std::endl << std::endl;

delete dis;
delete gen;
delete rd;

return SamplePoints;
}

Expand Down

0 comments on commit eae46f4

Please sign in to comment.