chore: hide ignite scaffold flutter
#2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 25, 2022 09:46
aljo242
requested review from
ilgooz,
lumtis,
jeronimoalbi,
tbruyelle and
fadeev
as code owners
added 2 commits
October 25, 2022 09:51
|
I would vote to remove the support if nobody is maintaining it. Also, regarding Dart, removing it might also be a good idea if nobody is maintaining it either, it seems that at the moment it is not working, see #2905. |
|
Since we're not maintaining it I suppose we can remove the functionality as well. By the time we revisit mobile support, it's probably going to be out of date anyways and one can always go back in Git history and see how it was implemented. |
|
Visit the preview URL for this PR (updated for commit 8db4472): https://ignitesrvc-d--pr2991-chore-hide-flutter-h9547rwg.web.app (expires Wed, 02 Nov 2022 13:14:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 60382552e86c69890c026e09478220ea153394a8 |
jeronimoalbi
approved these changes
Oct 26, 2022
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* remove flutter command * remove command * deprecate * changelog * remove from docs * remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2975
Keeps the internal functionality, but just removes the exposed command. If we maintain the functionality internally, but just deprecate it.
Perhaps we can remove altogether, but I wanted to check with y'all first.