Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove stargate in ignite/templates #3071

Merged
merged 18 commits into from
Nov 9, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Nov 7, 2022

Part of #3028

Closes #1737

Remove any trace of stargate in the templates package. Folders named stargate were renamed to files and the directory structure has been slightly reworked in places to make things a bit more organized.

@aljo242 aljo242 marked this pull request as ready for review November 7, 2022 15:17
tbruyelle
tbruyelle previously approved these changes Nov 7, 2022
Copy link
Contributor

@tbruyelle tbruyelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I tested all the changed scaffolders, and ignite c serve runs well after each of them, despite for the list but I suggested a fix.

Nice change!

Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Alex Johnson and others added 2 commits November 7, 2022 12:23
@aljo242
Copy link
Contributor Author

aljo242 commented Nov 7, 2022

Thanks @tbruyelle !

@lumtis
Copy link
Contributor

lumtis commented Nov 7, 2022

Solving #1737?

@aljo242 aljo242 merged commit 6746da0 into develop Nov 9, 2022
@aljo242 aljo242 deleted the refactor/remove-stargate branch November 9, 2022 18:49
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* app and ibc

* message

* module

* query

* testutil

* typed

* changelog

* rename fs

* generators

* remaining

* format

* Update ignite/templates/typed/list/list.go

Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>

* Update ignite/templates/typed/list/list.go

Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>

Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Templates: removing notion of Stargate
3 participants