-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove stargate
in ignite/templates
#3071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
aljo242
requested review from
ilgooz,
lumtis,
jeronimoalbi,
tbruyelle and
fadeev
as code owners
November 7, 2022 15:17
tbruyelle
reviewed
Nov 7, 2022
tbruyelle
reviewed
Nov 7, 2022
tbruyelle
previously approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I tested all the changed scaffolders, and ignite c serve
runs well after each of them, despite for the list
but I suggested a fix.
Nice change!
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Thanks @tbruyelle ! |
tbruyelle
approved these changes
Nov 7, 2022
Solving #1737? |
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* app and ibc * message * module * query * testutil * typed * changelog * rename fs * generators * remaining * format * Update ignite/templates/typed/list/list.go Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> * Update ignite/templates/typed/list/list.go Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com> Co-authored-by: Thomas Bruyelle <thomas.bruyelle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3028
Closes #1737
Remove any trace of
stargate
in thetemplates
package. Folders namedstargate
were renamed tofiles
and the directory structure has been slightly reworked in places to make things a bit more organized.