feat(network): param-change
#3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aljo242
requested review from
ilgooz,
lumtis,
jeronimoalbi,
tbruyelle and
fadeev
as code owners
added 2 commits
November 21, 2022 09:41
jeronimoalbi
approved these changes
Nov 21, 2022
|
@lubtd |
lumtis
reviewed
Nov 21, 2022
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
aljo242
added a commit
that referenced
this pull request
Dec 8, 2022
* update spn * import * fix * update mocks * rename test * feat(`network`): `param-change` (#3142) * utd * add command * typo * add test * changelog * format * Update ignite/cmd/network_request_param_change.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update changelog.md Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * refactor: rename command `param-change` into `change-param` (#3169) * change name * rename file * chore: upgrade `spn` (#3177) * gomod * gosum * endpoints (#3196) * format * request list * feat: add `ParamChange` to `ignite n request list/show` (#3233) * chore: go formatting (#3232) Co-authored-by: aljo242 <aljo242@users.noreply.github.com> * request list * format * ascii Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: aljo242 <aljo242@users.noreply.github.com> * format * feat(`network`): param-change apply to genesis (#3208) * stub out * prepare logic * fix test * Update ignite/services/network/networkchain/prepare.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * refactor WithKeyValueByte * add detail to error message * const format string * format * add integration test and fix * add check to command * format * finish check code * improve error msg * wip * fix * format * remove incorrect test * Update ignite/pkg/cosmosutil/genesis/genesis.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * rename according to review * optimize appylParamChanges * basic ModuleParamField test * format * revert errors Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> * add test * add test * flesh out genesis information tests * format Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: aljo242 <aljo242@users.noreply.github.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Jchicode
pushed a commit
to Jchicode/cli
that referenced
this pull request
Aug 9, 2023
* update spn * import * fix * update mocks * rename test * feat(`network`): `param-change` (ignite#3142) * utd * add command * typo * add test * changelog * format * Update ignite/cmd/network_request_param_change.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * Update changelog.md Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * refactor: rename command `param-change` into `change-param` (ignite#3169) * change name * rename file * chore: upgrade `spn` (ignite#3177) * gomod * gosum * endpoints (ignite#3196) * format * request list * feat: add `ParamChange` to `ignite n request list/show` (ignite#3233) * chore: go formatting (ignite#3232) Co-authored-by: aljo242 <aljo242@users.noreply.github.com> * request list * format * ascii Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: aljo242 <aljo242@users.noreply.github.com> * format * feat(`network`): param-change apply to genesis (ignite#3208) * stub out * prepare logic * fix test * Update ignite/services/network/networkchain/prepare.go Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> * refactor WithKeyValueByte * add detail to error message * const format string * format * add integration test and fix * add check to command * format * finish check code * improve error msg * wip * fix * format * remove incorrect test * Update ignite/pkg/cosmosutil/genesis/genesis.go Co-authored-by: Danilo Pantani <danpantani@gmail.com> * rename according to review * optimize appylParamChanges * basic ModuleParamField test * format * revert errors Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com> * add test * add test * flesh out genesis information tests * format Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: aljo242 <aljo242@users.noreply.github.com> Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2899
Only includes the command logic to send the requests to the chain. There is potential in the future to add some kind of logic to "check" that these param changes are valid.
The flow could be something like: