fix: Optimise ts-client generation #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clockworkgr
requested review from
ilgooz,
jeronimoalbi,
Pantani,
julienrbrt and
Ehsan-saradar
as code owners
github-actions
bot
added
component:ci
julienrbrt
approved these changes
Nov 2, 2023
jeronimoalbi
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some flaky issues that were coming up for me while running on Linux:
Changes:
nodetime.CommandSwaggerCombinecommand rather than generating a tmp binary each time (fixes flaky issues due to: os: StartProcess ETXTBSY race on Unix systems golang/go#22315)openapiv2version tov2.18.0which introduces anignore_commentsflag which allowsswagger-combineto merge multiple swagger.json files with no conflicts due to nom-matching comments/descriptions