Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing IBC commands for scaffolded chain #3836

Merged
merged 3 commits into from
Dec 12, 2023
Merged

fix: add missing IBC commands for scaffolded chain #3836

merged 3 commits into from
Dec 12, 2023

Conversation

Pantani
Copy link
Collaborator

@Pantani Pantani commented Dec 10, 2023

Description

Add mission querry and tx commands for IBC modules

@Pantani Pantani self-assigned this Dec 10, 2023
@github-actions github-actions bot added the component:ci CI/CD workflow and automated jobs. label Dec 10, 2023
@Pantani Pantani enabled auto-merge (squash) December 10, 2023 01:42
@Pantani Pantani changed the title fix: add ibc cli commands fix: add missing IBC commands for scaffolded chain Dec 10, 2023
@julienrbrt
Copy link
Member

That's a way to do it, but best to append it to the AutoCLI config options. As AutoCLI manages module commands now.

julienrbrt
julienrbrt approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this way looks less complicated than understanding the AutoCLI options for a new comer. Both can anyway be removed once IBC supports depinject.

@Pantani Pantani merged commit b0dd6a6 into main Dec 12, 2023
43 checks passed
@Pantani Pantani deleted the fix/add-ibc-cli branch December 12, 2023 03:55
@julienrbrt julienrbrt mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@salmad3 salmad3 salmad3 approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@Pantani Pantani

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pantani @julienrbrt @salmad3