Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add skip-proto flag to s chain command (backport #4019) #4030

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 18, 2024

Adds a --skip-proto flag to s chain to speed up scaffolding.
Advanced user can enjoy faster scaffolding time but still need to run ignite chain serve or ignite chain build afterwards.


This is an automatic backport of pull request #4019 done by Mergify.

Adds a `--skip-proto` flag to `s chain` to speed up scaffolding.
Advanced user can enjoy faster scaffolding time but still need to run `ignite chain serve` or `ignite chain build` afterwards.

(cherry picked from commit c05237b)

# Conflicts:
#	ignite/cmd/scaffold_chain.go
#	ignite/services/scaffolder/configs.go
#	ignite/services/scaffolder/init.go
#	ignite/services/scaffolder/params.go
Copy link
Contributor Author

mergify bot commented Mar 18, 2024

Cherry-pick of c05237b has failed:

On branch mergify/bp/release/v28.x.y/pr-4019
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit c05237b5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/services/scaffolder/message.go
	modified:   ignite/services/scaffolder/module.go
	modified:   ignite/services/scaffolder/packet.go
	modified:   ignite/services/scaffolder/query.go
	modified:   ignite/services/scaffolder/scaffolder.go
	modified:   ignite/services/scaffolder/type.go
	modified:   ignite/templates/app/files/app/ibc.go.plush

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   ignite/cmd/scaffold_chain.go
	deleted by us:   ignite/services/scaffolder/configs.go
	both modified:   ignite/services/scaffolder/init.go
	deleted by us:   ignite/services/scaffolder/params.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:templates component:configs component:cmd type:services Service-related issues. labels Mar 18, 2024
@julienrbrt julienrbrt self-assigned this Mar 18, 2024
@julienrbrt julienrbrt enabled auto-merge (squash) March 18, 2024 23:18
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 24.74%. Comparing base (0d9b9f6) to head (f83f783).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v28.x.y    #4030      +/-   ##
===================================================
- Coverage            24.74%   24.74%   -0.01%     
===================================================
  Files                  297      297              
  Lines                24977    24979       +2     
===================================================
  Hits                  6180     6180              
- Misses               18229    18231       +2     
  Partials               568      568              
Files Coverage Δ
ignite/services/scaffolder/init.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/message.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/module.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/oracle.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/packet.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/query.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/type.go 38.18% <0.00%> (ø)
ignite/cmd/scaffold_chain.go 0.00% <0.00%> (ø)
ignite/services/scaffolder/scaffolder.go 0.00% <0.00%> (ø)

@julienrbrt julienrbrt merged commit 98fe93b into release/v28.x.y Mar 19, 2024
41 of 44 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4019 branch March 19, 2024 07:44
@jeronimoalbi
Copy link
Member

jeronimoalbi commented Mar 19, 2024

The PR was automatically merged after the second approval but the CI was still running, I triggered it again because there was a failure which I believe it was a flaky test given that the origin of this backport worked.

I believe merge should wait for the CI to finish, if that's possible.

cc @julienrbrt

@julienrbrt
Copy link
Member

Agree, we should make the same job as on main required on release branches. Cc @ilgooz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants