Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): re-enable cobra __complete command #4033

Merged
merged 9 commits into from
Apr 4, 2024
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 18, 2024

Closes: #4028

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs component:cmd labels Mar 18, 2024
@julienrbrt julienrbrt added the backport/v28.x.y Backport to v28.x.y label Mar 19, 2024
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 26.09%. Comparing base (bc57707) to head (4141546).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4033      +/-   ##
==========================================
- Coverage   26.09%   26.09%   -0.01%     
==========================================
  Files         304      304              
  Lines       25594    25592       -2     
==========================================
- Hits         6680     6678       -2     
+ Misses      18326    18325       -1     
- Partials      588      589       +1     
Files Coverage Δ
ignite/cmd/completion.go 0.00% <ø> (ø)
ignite/cmd/cmd.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@julienrbrt julienrbrt marked this pull request as ready for review April 3, 2024 14:53
@julienrbrt julienrbrt merged commit 777e64a into main Apr 4, 2024
45 of 46 checks passed
@julienrbrt julienrbrt deleted the julien/completion branch April 4, 2024 07:43
mergify bot pushed a commit that referenced this pull request Apr 4, 2024
* fix(cmd): re-enable cobra `__complete` command

* changelog

* nits

* nits

* updates

* updates

(cherry picked from commit 777e64a)
julienrbrt added a commit that referenced this pull request Apr 4, 2024
* fix(cmd): re-enable cobra `__complete` command (#4033)

* fix(cmd): re-enable cobra `__complete` command

* changelog

* nits

* nits

* updates

* updates

(cherry picked from commit 777e64a)

* fix changelog

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt added a commit that referenced this pull request May 29, 2024
* fix(cmd): re-enable cobra `__complete` command

* changelog

* nits

* nits

* updates

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fish auto completions throw error
2 participants