Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(templates): add CollectionsKeyValueName to field.DataType #4131

Merged
merged 9 commits into from
May 15, 2024
Merged

feat(templates): add CollectionsKeyValueName to field.DataType #4131

merged 9 commits into from
May 15, 2024

Conversation

julienrbrt
Copy link
Member

  • Refactors dataTypeToCollectionKeyValue to directly integrate it in field.DataType
  • Add bytes data type

Pantani
Pantani previously approved these changes May 13, 2024
View reviewed changes
ignite/templates/field/datatype/bytes.go Outdated Show resolved Hide resolved
@julienrbrt @Pantani
imports
c9a4a8e 
Co-authored-by: Danilo Pantani <danpantani@gmail.com>
@julienrbrt julienrbrt requested a review from Pantani May 15, 2024 07:35
Pantani
Pantani reviewed May 15, 2024
View reviewed changes
ignite/templates/field/field.go Outdated Show resolved Hide resolved
ignite/templates/field/datatype/coin.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt requested a review from Pantani May 15, 2024 10:17
@Pantani Pantani merged commit ae58e83 into main May 15, 2024
46 checks passed
@Pantani Pantani deleted the julien/datatype-bytes branch May 15, 2024 11:46
julienrbrt added a commit that referenced this pull request May 29, 2024
@julienrbrt @Pantani
feat(templates): add CollectionsKeyValueName to field.DataType (#…
4821e3e 
…4131)

* feat(templates): add `CollectionsKeyValueName` to `field.DataType`

* pr number

* typo

* imports

Co-authored-by: Danilo Pantani <danpantani@gmail.com>

* fix cache

* feedback

---------

Co-authored-by: Danilo Pantani <danpantani@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @Pantani