Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template): rm dash in proto pkg names #649

Merged
merged 1 commit into from
Jan 18, 2021
Merged

fix(template): rm dash in proto pkg names #649

merged 1 commit into from
Jan 18, 2021

Conversation

ilgooz
Copy link
Member

@ilgooz ilgooz commented Jan 15, 2021

fixes #641.

@ilgooz ilgooz changed the title fix(template:) rm dash in proto pkg names fix(template): rm dash in proto pkg names Jan 15, 2021
Copy link
Contributor

@fadeev fadeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilgooz ilgooz merged commit 3cc4039 into develop Jan 18, 2021
@ilgooz ilgooz deleted the fix/dash-proto branch January 18, 2021 05:49
faddat added a commit that referenced this pull request Jan 21, 2021
* https://github.com/tendermint/starport: (94 commits)
  fix: change "frontend" to "vue" in gitignore (#674)
  feat(serve): save state as genesis when the app is stopped (#666)
  fix(relayer): update version (#640)
  feat(scaffold): upgrade Stargate to SDK v0.40.1 (#663)
  feat(scaffolder): init and export genesis for scaffolded types (#661)
  refactor(templates): rm internal/ from Stargate scaffold (#659)
  refactor: move Stargate app's third_party/proto into proto/third_party (#658)
  fix(docs): typo on custom modules
  feat: integrate app's protocgen script into starport (#654)
  fix: starport-docs-tutorials Introduction.md file (#653)
  fix(template:) rm dash in proto pkg names (#649)
  fix: add d to appname (#652)
  Update install info (#650)
  docs: update docs stargate (#648)
  feat: add cosmosfaucet (#630)
  feat: import wasm with Stargate (#642)
  feat: Pi for stargate (#627)
  feat(scaffolder): run fmt on scaffolder commands (#647)
  docs: added info on config (#646)
  feat: custom keyring-backend in config (#637)
  ...
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove invalid characters from username and repo before using it for proto packages
2 participants