-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPARK-2341 Improve signup wizzard #877
base: master
Are you sure you want to change the base?
Conversation
Excellent! Is it possible to make domains taken from existing accounts on the computer? For example, as an administrator in my company, I did not want users to create accounts on the Internet. |
I think that a proper way would be to register in LDAP by and admin and disable the Signup button with Anyway, the PR doesn't make anything worth but will help for inexperienced users. |
I don't know how exactly the Spark is used in a corporate environment. The list doesn't really needs to be maintained. Currently there is only three servers that I tested to work without a CAPTCHA (that is not implemented yet). So users who don't know what is the server may easily register at least somewhere. This is level 1 of help. Level 0 would be to add a link https://xmpp.org/getting-started/#2-create-an-account as the Gajim does. I just didn't had enough time for this. Later we can add support of CAPTCHA and uncomment other servers. Add servers from existing accounts is a good idea. We may add this too, just not sure how it will be useful given that most users have only one account. As another solution to autodetect the XMPP server we can check if the computer is in a domain and make a DNS request to the controller to find XMPP in the SRV records. Or just add it to the list and user may try to register there. The env As a side improvement we can add known servers as a dropdown to autocomplete As you see, that's all improvements that doesn't discard the PR itself but can be built upon it. |
I think the idea of a computer domain + a DNS request to the controller is an excellent solution. |
Ok, we may try to implement this. But I don't have enough time now. Meanwhile I added a check if a server supports registration and even added a rendering of a form. |
For a comparison I checked how the registration is handled in other apps. It gets the CAPTCHA image from Other implementations are tracked here https://invent.kde.org/melvo/xmpp-providers/-/issues/44 |
Added downloading providers, there is a simple JSON version that can be parsed without a JSON library. |
…h providers Make it easier for user to pick a server. Hardcode providers list, for now only A class.
Also rename the btnCreateAccount to btnSignUp and createAccountButton to signUpButton
Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
… service_unavailable Similar to 2913b3c Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
…if registration is allowed Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
@Plyha could you please review the PR?
I'll do this later in a separate PR. This looks like not so difficult to implement but I need more time to investigate if the ENV variables are set on Windows. |
First changes for the https://igniterealtime.atlassian.net/browse/SPARK-2341
I'll continue on this in a few months later because the current changes are already useful and will allow to users to get an account more easily so the main goal is achieved.