Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport collide bitmask changes #223

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 24, 2020

backport of pull request #160

replaces pull request #221

@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #223 into ign-gazebo3 will increase coverage by 0.99%.
The diff coverage is 60.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo3     #223      +/-   ##
===============================================
+ Coverage        65.14%   66.13%   +0.99%     
===============================================
  Files              127      125       -2     
  Lines             6303     5880     -423     
===============================================
- Hits              4106     3889     -217     
+ Misses            2197     1991     -206     
Impacted Files Coverage Δ
src/systems/physics/Physics.cc 33.84% <55.55%> (+0.27%) ⬆️
src/systems/physics/Physics.hh 100.00% <100.00%> (+9.09%) ⬆️
src/ServerPrivate.cc 30.97% <0.00%> (-30.44%) ⬇️
src/ServerConfig.cc 66.12% <0.00%> (-25.81%) ⬇️
src/Server.cc 72.05% <0.00%> (-13.98%) ⬇️
src/SimulationRunner.cc 81.02% <0.00%> (-4.16%) ⬇️
src/systems/log/LogRecord.cc
src/systems/log/LogPlayback.cc

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aef19...e094bd8. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should just add the lines back to the changelog.

Changelog.md Outdated Show resolved Hide resolved
@iche033 iche033 force-pushed the 4_to_3_collide_bitmask_20200624 branch from 632d48d to eb7408f Compare June 25, 2020 00:11
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 force-pushed the 4_to_3_collide_bitmask_20200624 branch from eb7408f to e094bd8 Compare June 25, 2020 00:13
Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting through this! (apologies for not targeting citadel in the first place)

@iche033 iche033 merged commit 26f9173 into ign-gazebo3 Jun 30, 2020
@iche033 iche033 deleted the 4_to_3_collide_bitmask_20200624 branch June 30, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants