-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport collide bitmask changes #223
Conversation
129f3fe
to
632d48d
Compare
Codecov Report
@@ Coverage Diff @@
## ign-gazebo3 #223 +/- ##
===============================================
+ Coverage 65.14% 66.13% +0.99%
===============================================
Files 127 125 -2
Lines 6303 5880 -423
===============================================
- Hits 4106 3889 -217
+ Misses 2197 1991 -206
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should just add the lines back to the changelog.
632d48d
to
eb7408f
Compare
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
eb7408f
to
e094bd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting through this! (apologies for not targeting citadel in the first place)
backport of pull request #160
replaces pull request #221