Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/request data #5

Merged
merged 18 commits into from
Apr 26, 2023
Merged

Feature/request data #5

merged 18 commits into from
Apr 26, 2023

Conversation

igords-goncalves
Copy link
Owner

@igords-goncalves igords-goncalves commented Apr 26, 2023

Description

This pull request create a pop fixed in right position and posts provided by a mocked json file

Review

  • Fixed position of modal
  • Consuming datas from json file
  • Created button back to top

Pre-merge checklist

  • The PR relates to a single subject with a title and description in grammatically correct, complete sentences?
  • verify that feature branch is up-to-date with master (if not -rebase it).
  • Double check the wuality of commit messages.
  • Squash related commits together.

Screenshots

Before After
image image

@igords-goncalves igords-goncalves merged commit bd31ff0 into master Apr 26, 2023
@igords-goncalves igords-goncalves deleted the feature/request-data branch April 26, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant