-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weighted incidence #303
Weighted incidence #303
Conversation
Hi @ntamas ,
I did not modify other parts of code. Now to maintain homogeneity:
|
I think i haven't handled negative weight scenario. I will refer to behavior w.r.t R implementation and accordingly handle in python. |
@ntamas Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contribution! I have requested a few minor changes, but otherwise it seems good to go. I'll merge this when the requests are addressed.
09025f6
to
07cf844
Compare
1f8d430
to
1d1d9b8
Compare
@ntamas why is wheel build is not happening in win32 x86 system? How to debug this issue? |
This is probably an issue with the C core and is unrelated to your PR. I'll merge this and then fix the failing build in a separate commit. Thanks for your contribution! |
I requested it and it was added YEARS ago: igraph/python-igraph#303
Fixes Issue: #229
I have handled following cases w.r.t permutations of params:
ValueError
when multiple and weighted can not co-exist.weighted=True
graph becomes weighted with edge_attr=weight
weighted="some_str"
graph is un-weighted with edge_attr=some_str
directed=True, mode="out", weighted=True
graph is weighted, directionout
is respcteddirected=True, mode="in", weighted=True
graph is weighted, directionin
is respcteddirected=True, mode="all", weighted=True
graph is weighted, directionall
is respcted