Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added to README that screen refresh may be neccesary to reflect settings #1062

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

peno022
Copy link
Contributor

@peno022 peno022 commented Sep 30, 2023

When I first began using videospeed, I was wondered why the new settings didn't take effect even after I modified them on the configuration screen and clicked the Save button. The solution was simple: I just had to refresh the tab where the video was playing.
It's a minor detail, but I wanted to mention it just in case.

@peno022
Copy link
Contributor Author

peno022 commented Nov 14, 2023

I'm new to contributing to OSS and apologize if there are any shortcomings in my pull request.
I understand that you are likely very busy, but when you have a moment, could you please review my pull request? It's a minor addition to the README for the videospeed extension.

I am more than willing to make any necessary revisions or improvements based on your feedback.
Thank you for your time and consideration.

Best regards,

@igrigorik
Copy link
Owner

Thank you, great addition and welcome to the OSS contributor family!

@igrigorik igrigorik merged commit 55782ca into igrigorik:master Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants