Add support for excluding files when building images #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "*.html") via the new '-x' switch. File exclusion is powered by the fnmatch() function. In MinGW, libiberty.a (under MSYS) has the implementation, but there is no header file that declares it so the function declaration was added to the top of main.cpp for now. This is not ideal and it has not been tested in any other platforms yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone,
I've put together a change to allow for the exclusion of files duging the creation of SPIFFS images. I wondering if people would find it useful.
My main concern with this change is the introduction of a dependency on the
fnmatchfunction. For MinGW, I found an implementation in libiberty.a (I couldn't find a declaration in any of the header files I have though so I added one manually). However, I don't have easy access to other platforms, so assuming this change is desirable, I'd need help figuring out that dependency on other platforms as well. Due to this, I'm marking this PR as a draft for now.Let me know what you think.
Thanks.