Support reading and writing ESP32 file timestamps stored in the metadata #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bytes by using CONFIG_SPIFFS_USE_MTIME=1 and CONFIG_SPIFFS_META_LENGTH=4 compile flags.
igrr
reviewed
May 22, 2019
main.cpp
Outdated
| #if CONFIG_SPIFFS_USE_MTIME | ||
| struct stat sbuff; | ||
| stat(path, &sbuff); | ||
| SPIFFS_fupdate_meta(&s_fs, dst, &sbuff.st_mtime); |
There was a problem hiding this comment.
Can you please handle the possibly different sizeof(time_t) explicitly? E.g.
uint32_t meta = (maybe truncate?) sbuff.st_mtime;
SPIFFS_fupdate_meta(&s_fs, dst, &meta);
And similar in unpackFile below.
and the SPIFFS image file, take into account that the word size and endianness of the host architecture may be different to that stored in the image file.
|
@igrr My latest commit goes one step further by also taking into consideration the host architecture endianness. I trust that is in the spirit of what you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... bytes by using CONFIG_SPIFFS_USE_MTIME=1 and CONFIG_SPIFFS_META_LENGTH=4
CPPFLAGS compile flags.
The ESP IDF stores file timestamps in 4 bytes of SPIFFS meta data. By using the above compile flags, this patch restores those timestamps when extracting files from a SPIFFS image file and recreates those timestamps by copying from the sources file(s) when creating a SPIFFS image file.