Adding additional options for duplicate reads. #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh, I seem to have an test failure... I'll look into that... |
|
Fixed. I made the faulty assumption that renderOptions wasn't allowed to be null there. |
|
I love the feature. I wonder if the options should be verbs, i.e "filter", "show", and "texture". I guess texture isn't a verb, can I texture something? Or space isn't a problem, we could be explict, "filter duplicates", "show duplicates", and "texture duplicates". Again I'm not sure texture is really a verb, but its close enough in context. |
|
Apparently it can be used as a verb as well. I like making them verbs since it feels more like an action you're performing in the app. |
* new GroupBy duplicates option * new Duplicates submenu which allows rapid toggling of duplicates between three states * Filtered: not visible * Visible: treated like normal reads * Textures: rendered with a visible slash texture
lbergelson
force-pushed
the
lb_duplicate_coloring
branch
from
bdeaf1c
to
71b357d
Compare
jrobinso
reviewed
Aug 18, 2024
| case PHASE: | ||
| return al.getAttribute("HP"); | ||
| case TAG: | ||
| return switch (groupBy) { |
There was a problem hiding this comment.
This is a big improvement.
jrobinso
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to a feature request from @rickymagner. It doesn't seem like there was any way to see which reads are duplicates. Added some new options to help.
Showing the new grouping and cross hatching
The new menu option
