Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description #24

Open
wants to merge 4 commits into
base: live
Choose a base branch
from
Open

Update description #24

wants to merge 4 commits into from

Conversation

duboism
Copy link
Collaborator

@duboism duboism commented Sep 27, 2024

This PR implements some changes in the description of the app.

  • Correct repository URL
  • Add credits
  • Remove duplicated paragraph
  • Update list of latest LVK publications Not necessary after some checks

@rachelmgray
Copy link
Collaborator

Hi Mathieu, the changes look okay to me, the only thing missing is an updated link for the list of LVK publications. This might be the best option? (The current list is outdated, and the other list I found was very LSC specific, whereas this at least includes LVK in the title). Might be worth checking in with EPO to see if they have a better alternative, however...

@duboism
Copy link
Collaborator Author

duboism commented Sep 30, 2024

@rachelmgray, thanks for reminding me this. The current page doesn't seem too outdated (last entry if from July 2024); the page you pointed out is targeted toward the general public so I'm not sure if this fits. Maybe it's better to contact the EPO team directly. Perhaps, we can even suggest to create a webpage dedicated to the official Hubble constant measurement.

I marked the PR as draft while we work on that.

@duboism duboism marked this pull request as draft September 30, 2024 10:33
@rachelmgray
Copy link
Collaborator

Hi Mathieu, huh, when I looked at that page originally the most recent publication was 2020 (hence the concern). I've now tried clicking the Release Date and it's updated to include everything to 2024. Maybe it was just remembering some weird settings from when I previously visited, though that's a little concerning as I had visited multiple times without an indication that it was a subset of results. Either way probably fine to leave it for now.

@duboism duboism marked this pull request as ready for review September 30, 2024 21:36
@duboism
Copy link
Collaborator Author

duboism commented Sep 30, 2024

Hi Rachel,

The web is full of surprises :)

I will switch the PR to ready for review. If I remember correctly, 2 people mentioned in CODEOWNERS must approve it.

Copy link
Collaborator

@rachelmgray rachelmgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR addresses the changes to the website text as required.

@NicolaTamanini NicolaTamanini self-requested a review October 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants