Minor fixes and added "Album artist" tag #212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I tried to change the artist tags to make them the same as when downloaded through the bandcamp website, for example:
Some music player apps will say that an album has no artist if only the "artist" tags are filled but not "album artist", it's also pretty annoying downloading splits or compilations and having the artists in the track name, instead of the artist tag where they belong.
So, this fork should behave the same as when downloading from bandcamp's website. I've tested it on 3 different cases (single, album by a single artist, album by multiple artists) and so far it seems OK. The changes are:
And some minor things I came across along the way:
PS: sorry in advance if I'm doing something wrong, it's my first time making a pull request :-)