TLS Cipher Workaround #234
Conversation
kjake
commented
Aug 27, 2024
kjake
commented
- Implements manual TLS cipher selection to workaround a server-side configuration issue with bandcamp.com
- Used sample code from bandcamp 403 with urllib-2.2.x (worked with urllib-1.26.x) urllib3/urllib3#3439 (comment) - thanks to @pquentin!
- Implements manual TLS cipher selection to workaround a server-side configuration issue with bandcamp.com - Used sample code from urllib3/urllib3#3439 (comment) - thanks to @pquentin! Co-Authored-By: Quentin Pradet <42327+pquentin@users.noreply.github.com>
|
Figured it was something oddball, every time I've ran into a major issue that couldn't be fixed debugging bandcamp-dl itself its always been library related smh |
| else: | ||
| urls = arguments.URL | ||
|
|
||
| album_list = [] | ||
|
|
||
| for url in urls: | ||
| if "/album/" not in url and "/track/" not in url: |
There was a problem hiding this comment.
Any specific reasoning for this?
There was a problem hiding this comment.
Ah I see this is related to #233 and just got carried over.
There was a problem hiding this comment.
In my testing the urls list often (always?) contains a top-level url of the artist without any albums or tracks, and is the first in the list, causing bandcamp-dl to immediately fail.
This could potentially be fixed in get_full_discography(), but I'm not that good at python.
| @@ -86,7 +86,6 @@ def main(): | |||
| logger = logging.getLogger(logging_handle) | |||
|
|
|||
| # TODO: Its possible to break bandcamp-dl temporarily by simply erasing a line in the config, catch this and warn. | |||
| arguments = config.init_config(parser) | |||
There was a problem hiding this comment.
You remove config initializing?
There was a problem hiding this comment.
init_config() was removed by #229 and bandcamp-dl would no longer run for me unless I removed that line.
There was a problem hiding this comment.
Looks like the merge for that PR did not go properly considering its still there, hopefully nothing else slipped through.
EDIT: Ah I see, they removed the function but did not seem to remove the call to it oddly enough.
There was a problem hiding this comment.
Yup, and my change resolved #232 for me. No idea if something else is broken because of the changes the other PR made though.
