Add soemJavaNativeLibrary and support cross compilation for aarch64 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ds58
changed the title
ds58
commented
Nov 18, 2024
Comment on lines
+20
to
+22
| api("us.ihmc:soem:1.5.0") | ||
| api("us.ihmc:soem-platform-linux-x86_64:1.5.0") | ||
| api("us.ihmc:soem-platform-linux-arm64:1.5.0") |
There was a problem hiding this comment.
Will have to publish these
There was a problem hiding this comment.
Looks good. Looks like that's why the checks are failing. Maybe you should go ahead and publish so the tests in the PR pass?
There was a problem hiding this comment.
Sure, note that there is 1 failing test on develop already
reesep5
reviewed
Nov 18, 2024
| cd build | ||
| cmake -DCMAKE_BUILD_TYPE=Release .. | ||
| # Cross compile for arm64 using the toolchain | ||
| # cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_TOOLCHAIN_FILE=../linux-aarch64-toolchain.cmake .. |
There was a problem hiding this comment.
I assume this means we need to run this on any arm64 machine?
There was a problem hiding this comment.
When running on a native arm platform you don't need to use the cross compilation toolchain
reesep5
approved these changes
Nov 18, 2024
calvertdw
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.