Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sparse xarray for reporting.Quantity #191

Closed
khaeru opened this issue Sep 27, 2019 · 5 comments
Closed

Use sparse xarray for reporting.Quantity #191

khaeru opened this issue Sep 27, 2019 · 5 comments
Labels
reporting Post-processing of model results

Comments

@khaeru
Copy link
Member

khaeru commented Sep 27, 2019

xarray 0.13 includes support for converting pd.DataFrame to a pydata/sparse data structure.
This should mostly obviate the need for the custom AttrSeries class.
A PR should be opened to make the change, test performance, and make any necessary adjustments.

Resources:

@khaeru khaeru added the reporting Post-processing of model results label Sep 27, 2019
@francescolovat francescolovat self-assigned this Dec 5, 2019
@khaeru khaeru changed the title Use sparse xarray for reporting.utils.Quantity Use sparse xarray for reporting.Quantity Apr 25, 2020
@khaeru
Copy link
Member Author

khaeru commented Jun 20, 2020

#317 / iiasa/message_ix#372 partly addresses this issue; however, we still await a release of xarray >0.15.1 (see pydata/xarray#4031) to fix pydata/xarray#4019, which causes incorrect computation results in sparse-backed xarray.DataArray.

@khaeru
Copy link
Member Author

khaeru commented Aug 26, 2020

we still await a release of xarray >0.15.1 (see pydata/xarray#4031) to fix pydata/xarray#4019

This is now fixed & released.

@francescolovat
Copy link
Contributor

Based on your previous comment, @khaeru, can we close this issue?

@khaeru
Copy link
Member Author

khaeru commented Oct 21, 2020

can we close this issue?

In short, no. That was an issue which blocked this one.

The block is now cleared, but we would still need to have a PR to implement the changes described here.

@khaeru
Copy link
Member Author

khaeru commented Feb 17, 2021

This is to be continued at khaeru/genno#23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reporting Post-processing of model results
Projects
None yet
Development

No branches or pull requests

2 participants