Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to ixmp#317 #372

Merged
merged 5 commits into from
Jun 20, 2020
Merged

Adjust to ixmp#317 #372

merged 5 commits into from
Jun 20, 2020

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Jun 19, 2020

iiasa/ixmp#317 cleans up the reporting.Quantity semantics/API so that they are completely agnostic with respect to the internal data format. That's to make it easier to later swap ixmp.reporting.attrseries (a wrapped pd.Series) for ixmp.reporting.sparsedataarray (an xr.DataArray with pydata/sparse storage).

This PR adjusts message_ix.reporting to avoid calling pd.Series-specific methods, and instead use the general Quantity API.

How to review

PR checklist

  • Tests adjusted.
  • Documentation added.
  • Release notes updated. N/A; no UX changes.

@khaeru khaeru merged commit 937c247 into iiasa:master Jun 20, 2020
@khaeru khaeru deleted the for-ixmp-317 branch June 20, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant