Streamline tests #128
Merged
Streamline tests #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ixmp.testing: new submodule for reuse of testing utilities.
- create_local_testdb(): moved from tests/testing_utils.py
- dantzig_transport(): replaces code in tests/test_integration.py and
tests/testdb_setup.py.
- consolidate test data in tests/data.
- ixmp.Platform.__init__: ensure dbprops is string, for Java compat.
- ixmp.default_paths: use Path objects.
- tests/conftest.py:
- new fixtures: test_data_path, tutorial_path.
- existing test_mp* fixtures: add docstrings, use tmp_path_factory
fixture.
- new hook: pytest_report_header (replaces test_admin.py).
- other tests: use pytest & ixmp fixtures.
- test_mp_use_db_config_path, test_mp_use_default_dbprops_file - expand tests/test_core.py to include this behaviour directly
|
Okay, finally all the tests pass. This is ready to review & merge, from my POV. |
danielhuppmann
requested changes
Mar 11, 2019
There was a problem hiding this comment.
thanks @khaeru! two minor suggestions...
and one question: in the current setup, the local default HSQLDB is touched every time a user re-installs and runs the tests on the tutorial notebooks. So the default database files become quite bloated over time. Would it be possible to connect the tutorial-notebook tests to a temporary db?
As mentioned in Slack, this is possible, but it requires new functionality. Related to #124. I would prefer to merge this PR and then work on the other issue. |
danielhuppmann
approved these changes
Mar 12, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: this PR makes better use of pytest features instead of reinventing them in multiple places. It also moves some testing code to a new
ixmp.testingsubmodule so it can be reused by message_ix (e.g. this shouldn't need redefinition) or by users.I started making some of these changes when writing tests for #126 and figured they could stand alone.
tests/testdb_setup.py.
fixture.
PR checklist: