Add IXMP_DATA / execute all tests in temporary directories #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New class ixmp.config.Config to regularize config handling. - Remove ixmp.default_paths, ixmp.default_path_constants. - cli.config(): use Config.save(). - Scenario__init__(): use Config.find_dbprops() and Config.get(). - conftest.py: new fixture 'tmp_env' and hook 'pytest_sessionstart'. - test_config.py: test Config features. - test_core.py: use pytest 'caplog' fixture to test that configuration values are used. - test_tutorials.py: use 'tmp_env' to force tutorial execution in a sandbox.
stickler-ci
reviewed
Mar 13, 2019
gidden
reviewed
Mar 29, 2019
gidden
reviewed
Mar 29, 2019
|
Hey @khaeru let me know if there's anything else to do here. Otherwise as soon as it passes, we can pull and continue with other PRs! |
|
Done, please go ahead and merge. |
|
thanks @khaeru, great addition! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code causes all tests to be executed in temporary directories, without touching the user's local database or configuration file. This is accomplished by checking a new environment variable
IXMP_DATA, which points to a directory that is used for bothconfig.jsonand theDEFAULT_LOCAL_DB_PATH. Along the way, handling of configuration keys is formalized a little.To check that the code works as advertised, one can make one's own (user) ixmp data directory read-only, e.g.
$ chmod -w ~/.local/share/ixmp. Then run the tests. The tests pass; this shows thatixmp-configcalls in tests, and any local databases created/used, are not written in this directory.Closes #124.
ixmp.config.Configto regularize config handling.ixmp.default_paths,ixmp.default_path_constantssubmodules.PR checklist: