-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test & improve perfomance in .tools.add_year #494
Draft
khaeru
wants to merge
7
commits into
main
Choose a base branch
from
test-add-year
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+255
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #494 +/- ##
=======================================
+ Coverage 94.4% 95.0% +0.6%
=======================================
Files 43 43
Lines 3432 3482 +50
=======================================
+ Hits 3241 3310 +69
+ Misses 191 172 -19
|
glatterf42
force-pushed
the
test-add-year
branch
from
March 3, 2023 09:06
3d43056
to
b9ab87a
Compare
glatterf42
force-pushed
the
test-add-year
branch
from
March 31, 2023 12:10
b9ab87a
to
4073d9a
Compare
1 task
3 tasks
This dedents most of the code one level.
glatterf42
force-pushed
the
test-add-year
branch
from
April 18, 2023 06:17
cece706
to
7a3d2ba
Compare
Filtering out commits that were included in #703 already. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most (137 of 187) untested lines in
message_ix
are in.tools.add_year
: https://codecov.io/gh/iiasa/message_ix/tree/master/message_ix/tools/add_yearThis PR adds tests for this code, but also reimplements some internal methods for better performance.
Partially addresses #433.
How to review
To be added.
PR checklist