Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link in install instructions #724

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Jun 27, 2023

As pointed out by Marek, the link to GitHub in footnote 2 of the install instructions was broken.

How to review

  • Read the diff and note that the CI checks all pass.
  • Build the documentation, look at the installation page, try to follow the link in 'Anaconda -> Step 4 -> Footnote 2'

PR checklist

@glatterf42 glatterf42 added bug Doesn't work as advertised/unintended effects docs Documentation labels Jun 27, 2023
@glatterf42 glatterf42 self-assigned this Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #724 (5e6836a) into main (3a8910b) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #724   +/-   ##
=====================================
  Coverage   94.4%   94.4%           
=====================================
  Files         43      43           
  Lines       3448    3448           
=====================================
  Hits        3257    3257           
  Misses       191     191           

@glatterf42 glatterf42 requested a review from khaeru June 27, 2023 09:04
@glatterf42
Copy link
Member Author

This PR could also be a vehicle for the suggested fix for actions/setup-python#682 (comment) if we don't want to wait for the changes to reach us naturally.

@glatterf42 glatterf42 merged commit cec4092 into iiasa:main Jun 28, 2023
18 of 19 checks passed
@glatterf42 glatterf42 deleted the fix/install branch June 28, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Doesn't work as advertised/unintended effects docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants