-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GitHub community standards #871
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=====================================
Coverage 95.6% 95.6%
=====================================
Files 46 46
Lines 4344 4344
=====================================
Hits 4154 4154
Misses 190 190 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all excellent and valuable material. I think it is very good practice to have clear statements of practice like this. It doesn't bind us to keeping things exactly the same forever (we can always update and amend these texts), but helps us notice when our actual practices and intent are starting to diverge.
A few suggested changes, but most of all let's discuss the CoC with the team and ensure we have consensus.
d6803d2
to
7255cd4
Compare
Thanks for the suggestion. As recommended in today's weekly meeting, let's try to have as many people as possible on board before introducing a Code of Conduct (CoC). So @iiasa/messageix-devs, please read through the proposed CoC and provide feedback here (or see below for a summary). If you are happy with these guidelines/rules, please leave a thumbs up; if you don't like them, please tell us what specifically you'd like to see changed. Please do this before the 15th of August. To add some context for the discussion about CoCs: What is it?A Code of Conduct (CoC) is intended to outline how everyone in the community should interact, signal a welcoming and inclusive community, and explain how misconduct can be reported/will be handled. What form can it take?In principle, this can be any document outlining (at least) the above (e.g. rust has written a unique one and is consistently one of the most popular programming languages). How do these compare?The first two are both rather formal and seem to differ only in details, Django seems more free-form and positive ("be welcoming", etc). What needs to be done?The main thing we would need to agree on: everyone should follow the outlined rules and take an active role in reporting misconduct, so that we actually enforce the CoC. For the Contributor Covenant, this means:
|
* Leave out google group intentionally to centralize information
2bc6536
to
9e8664d
Compare
Today, I stumbled upon GitHub's guidelines for establishing a healthy community. This PR includes various suggested files to improve the experience of working with
message_ix
.Apart from these files, GitHub also suggests to turn on various security features that we had not enabled, so I did that as well. That is why we are seeing new CI checks: GitHub checks if any
secrets
haven been accidentally included. We also now accept people directly reporting vulnerabilities in our code in private.One feature I'm not sure is working even though I did enable it is that the repository admins accept content reports (please see here for a check list). Not sure what's going on there, maybe we have to actually work through one report to show we accept them?
How to review
PR checklist
[ ] Add or expand tests; coverage checks both ✅Not touching code.