Add african subregions #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phackstock, all good to me, except that Gambia should be named "The Gambia". The Gambian people really don't like it when you omit the important "The" :)! |
|
@MohElabbas, we follow ISO 3166-1 conventions to ensure short and consistent country names, see https://en.wikipedia.org/wiki/ISO_3166-1. |
sandrinecharousset
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes openENTRANCE/openentrance#305.
This PR adds the African regions of:
along with aggregation instructions for currently:
@sandrinecharousset and @MohElabbas I've sent you the invite for a openmod4africa GitHub team. You'll need to accept in order to officially review this PR.
@MohElabbas, if you're ok with it I'd close openENTRANCE/openentrance#305 once this PR is merged.