Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to turn off timer mode #19

Closed
ikaruswill opened this issue May 21, 2020 · 6 comments · Fixed by #36
Closed

Unable to turn off timer mode #19

ikaruswill opened this issue May 21, 2020 · 6 comments · Fixed by #36

Comments

@ikaruswill
Copy link
Owner

There's currently no toggle-able state to turn off scheduled turn off.

@insajd
Copy link
Collaborator

insajd commented Jun 14, 2020

no. work in progress....

@insajd
Copy link
Collaborator

insajd commented Jun 14, 2020

See this line, https://github.com/syssi/python-miio/blob/1a52117eed74cc81a966df55582fe66be8821490/miio/fan.py#L561
It looks like we can't pass anything that turns timer mode off. We can turn off+on quickly the fan, that should reset the timer. Or, try to propose some changes to python-miio if it's possible to turn off this timer somehow...

@ikaruswill
Copy link
Owner Author

ikaruswill commented Jun 15, 2020

Yeah no work in progress on this at the moment, I wrote this issue from the angle that we can turn the timer off in the Mi Home App so I thought there shouldn't be a reason why we can't do it with python-miio.

My plan was to understand the code and possibly propose changes to python-miio but haven't got down to doing it.

@insajd
Copy link
Collaborator

insajd commented Jun 30, 2020

Created PR in rytilahti/python-miio#741 and syssi/xiaomi_fan#70
After they both are merged, this component will be able to disable scheduled turn off by passing 0 as value for delayed turn off.

@ikaruswill
Copy link
Owner Author

ikaruswill commented Jun 30, 2020 via email

@insajd
Copy link
Collaborator

insajd commented Jul 20, 2020

Iimplemented, needs https://github.com/syssi/xiaomi_fan develop branch currently. When there's release after 0.2.0, xiaomi fan card release can be released without -beta :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants