Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignored files #174

Closed
wants to merge 1 commit into from

Conversation

izderadicka
Copy link
Contributor

These files are ignored by git, but were pushed into repo in past.
They just mess with newly generated UI files.

Used :

git ls-files -i -c --exclude-standard | xargs git rm --cached

to get rid of them - I guess it could be useful also for main branch.

@ikatson
Copy link
Owner

ikatson commented Aug 10, 2024

As you can see, these files are needed for the build.
They are embedded into the binary so that /web/ URL works. They are in .gitignore so that no new generated files get added, only the ones explicitly added previously.

I agree they are annoying though. A better solution might be to run "npm build" as part of "build.rs".

@izderadicka
Copy link
Contributor Author

Thanks for explanation -I realized that rust build was problem, when I saw all jobs failed.
Just one note - adding them to .gitignore does not help, as long as they are in repo, they will always be shown as modified, after npm run build -

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   crates/librqbit/webui/dist/assets/index.css
        modified:   crates/librqbit/webui/dist/assets/index.js
        modified:   crates/librqbit/webui/dist/manifest.json
        modified:   crates/librqbit/webui/node_modules/.package-lock.json

no changes added to commit (use "git add" and/or "git commit -a")

No big issue - just requires bit more attention to what is included in commits.

@ikatson
Copy link
Owner

ikatson commented Aug 10, 2024

Yes that's expected. These files don't get generated during rust build, that's why they are committed.

But as I mentioned above, I think we need to get rid of them if favor of building npm in build.rs, cause these files are causing a bit of pain

@ikatson
Copy link
Owner

ikatson commented Aug 12, 2024

Addressed in #180

@ikatson ikatson closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants