implement Saturating #43
Conversation
|
I've implemented some tests, so this is probably ready for a review (whenever you get a chance, of course!) |
There was a problem hiding this comment.
First pass looks pretty good. Change commit message to "Implement num::Saturating\n\nPart of #35." The standard library also has saturating_mul which num::Saturating doesn't.
src/system.rs
Outdated
| where | ||
| D: Dimension + ?Sized, | ||
| U: Units<V> + ?Sized, | ||
| V: $crate::num::Saturating + $crate::num::Num + $crate::Conversion<V>, |
There was a problem hiding this comment.
Move Saturating after Conversion<V>.
src/system.rs
Outdated
| { | ||
| fn saturating_add(self, v: Self) -> Self { | ||
| Quantity {value: self.value.saturating_add(v.value), ..self} | ||
| } |
There was a problem hiding this comment.
Put a blank link after the closing }.
src/system.rs
Outdated
| V: $crate::num::Saturating + $crate::num::Num + $crate::Conversion<V>, | ||
| { | ||
| fn saturating_add(self, v: Self) -> Self { | ||
| Quantity {value: self.value.saturating_add(v.value), ..self} |
There was a problem hiding this comment.
Space before value. Space after ..self.
src/system.rs
Outdated
| Quantity {value: self.value.saturating_add(v.value), ..self} | ||
| } | ||
| fn saturating_sub(self, v: Self) -> Self { | ||
| Quantity {value: self.value.saturating_sub(v.value), ..self} |
There was a problem hiding this comment.
Space before value. Space after ..self.
|
Could you also add details to |
|
Thanks for the comments! I've addressed them and updated the branch. |
|
Could you move |
|
Done! Thanks for the reviews :) |
|
Looks like Appveyor found a pre-existing bug. Filed #48. |
|
Thanks! |
Part of #35.
While in general the test suite does not pass with integers enabled, the new tests do pass, and no new failures were introduced.