Add AngularMomentum (improved)
#479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netzwerk2
force-pushed
the
angular_momentum
branch
from
c6e0d59 to
0e662ef
Compare
|
Thanks so much for the PR and sorry for the delay reviewing. I pushed formatting and some minor fixes to your fork. Could you please review and squash and then I'll look to get everything merged. |
Closed
Netzwerk2
force-pushed
the
angular_momentum
branch
from
68ca9c4 to
6b58736
Compare
|
Looks good to me. Squashed them :) |
|
Merged! Thanks so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #460 and is based on #463.
I implemented testing like you suggested and also added newton meter second as a unit (all the prefixes are copied from torque).
For now, I kept kilogram square meter per second, but I don't know if that's in your interest.