This repository has been archived by the owner on Feb 3, 2024. It is now read-only.
Convert to monorepo #3663
Merged
Convert to monorepo #3663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
monorepo
branch
4 times, most recently
from
41d5422 to
daad676
Compare
Moved all the tests into the test-app - I had to remove the code coverage, hopefully temporarily. - Moved the linting up to the top level. This isn't the way it looks in the sample ember version, but it's the only way I could get everything working the way I expected. - Removed dotenv, use real ENV variables to configure
|
I'll need to reconfigure netlify after this is merged, so no click testing unfortunately. |
While all tests and everything from common worked well the tasks within the test app, such as login controller, didn't get transpiled correctly. Adding a direct dependency on this addon fixed that.
stopfstedt
approved these changes
Jan 25, 2024
| @@ -18,34 +18,23 @@ module.exports = { | |||
| }, | |||
| rules: { | |||
| 'ember/no-get': 0, | |||
| 'ember/use-brace-expansion': 0, | |||
There was a problem hiding this comment.
nice to shed these old rule-exceptions while at it.
There was a problem hiding this comment.
I was surprised at how few of them we needed. Gotta ad that to the maintenance list to check on these occasionally.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved all the tests into the test-app