Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation for the items with dot in ID broken for Laravel 7.0 #13

Closed
klimov-paul opened this issue Sep 9, 2020 · 1 comment
Closed

Validation for the items with dot in ID broken for Laravel 7.0 #13

klimov-paul opened this issue Sep 9, 2020 · 1 comment
Assignees
@klimov-paul
Labels
bug Something isn't working
Milestone
1.3.0

Comments

@klimov-paul
Copy link
Member

During the Laravel 7.0 development the way dot keys are handled during validation has been changed.
See:

laravel/framework@4a4a7e1#diff-38fd116b7c7b8ac1bdd8362250d04d57

Thus method PersistentRepository::validate() is unable to handle item ID with dots anymore.

Relates to laravel/framework#33932

This should be fixed along with upgrade to Laravel 8.0.
@klimov-paul klimov-paul self-assigned this Sep 9, 2020
@klimov-paul klimov-paul added the bug Something isn't working label Sep 9, 2020
@klimov-paul klimov-paul added this to the 1.3.0 milestone Sep 9, 2020
klimov-paul added a commit that referenced this issue Sep 9, 2020
@klimov-paul
#13: Fixed validation for the item ID containing dot ('.')
a8a1cfd
@klimov-paul
Copy link
Member Author

Resolved by commit a8a1cfd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klimov-paul klimov-paul

Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@klimov-paul