Add code snippet for Generate random numbers #116

asilenko · 2021-10-27T16:30:14Z

Added code snippet for Issue #105 :

created two methods:
-> for random number between x and y
-> for throwing dice
added tests for both methods,
updated Readme.md

iluwatar

In addition to the review comments, there is a merge conflict that needs to be resolved.

iluwatar · 2021-10-30T18:26:30Z

src/main/java/math/GenerateRandomNumbersSnippet.java

+     * @param y right bound
+     * @return random integer between x and y
+     */
+    public static int generateRandomNumberBetweenXAndY(int x, int y) {


I would suggest generateRandomNumberBetween (leave out the end)

iluwatar · 2021-10-30T18:29:31Z

src/main/java/math/GenerateRandomNumbersSnippet.java

+    /**
+     * Throw dice (3d6)
+     *
+     * @return random integer between 1 and 6 (inclusive)
+     */
+    public static int throwDice() {
+        return random.nextInt(5) + 1;
+    }


Maybe the function could take parameters of how many dice we have and what kind of dice it is. For example, parameters 3 and 6 would throw 3 times d6 dice giving a result between 3-18.

iluwatar · 2021-10-30T18:30:40Z

src/test/java/math/GenerateRandomNumbersSnippetTest.java

+    @Test
+    void testGenerateRandomNumberBetweenXAndY() {
+        var randomInteger0 = GenerateRandomNumbersSnippet.generateRandomNumberBetweenXAndY(0, 0);
+        assertEquals(0, randomInteger0);
+
+        var randomInteger1 = GenerateRandomNumbersSnippet.generateRandomNumberBetweenXAndY(3, 10);
+        var listOfPossibleResults1 = List.of(3, 4, 5, 6, 7, 8, 9, 10);
+        assertTrue(listOfPossibleResults1.contains(randomInteger1));
+
+        var randomInteger2 = GenerateRandomNumbersSnippet.generateRandomNumberBetweenXAndY(42, 43);
+        var listOfPossibleResults2 = List.of(42, 43);
+        assertTrue(listOfPossibleResults2.contains(randomInteger2));
+    }
+
+    /**
+     * Tests for {@link GenerateRandomNumbersSnippet#throwDice()}.
+     */
+    @Test
+    void testThrowDice() {
+        var number = GenerateRandomNumbersSnippet.throwDice();
+        var listOfPossibleResults = List.of(1, 2, 3, 4, 5, 6);
+        assertTrue(listOfPossibleResults.contains(number));
+    }


I think parameterized tests would be very useful here to test more thoroughly. See https://www.baeldung.com/parameterized-tests-junit-5

Parameterized tests added. I'm new to junit, thanks for the opportunity to learn.

asilenko · 2021-11-06T15:38:40Z

Ready for review.

iluwatar

You need to fix the failing build

asilenko · 2021-11-20T07:39:51Z

You need to fix the failing build

I had some trouble working with checkstyle.xml It seems to be OK by now.
In addition I added one new test to check if all numbers from given range were generated.

iluwatar

The build is still failing due to Checkstyle issue. Please set up your IDE to work with Checkstyle and run the checks locally before submitting changes for review.

asilenko · 2022-01-08T22:38:53Z

Sorry for the delay. Hope this last commit has fixed the problem with the checkstyle. I'm new to gradle. The project still do not build on my device but the reason is build.gradle file. I'm not sure if I should fix it along with this issue. Let me know if it's ok.

iluwatar

The build is still failing due to the missing license header and Checkstyle issues.

iluwatar · 2022-01-09T15:01:34Z

@asilenko I added some more instructions in the PR #119 Maybe you find that helpful.

asilenko · 2022-01-09T17:52:20Z

@asilenko I added some more instructions in the PR #119 Maybe you find that helpful.

Thank you. I fixed the licence, but I don't see any checkstyle warning when I try to build the project. If it still does not work just pass the task to someone else. Sorry for wasting your time.

grzesiekkedzior · 2022-01-09T22:23:51Z

Ok, @asilenko I checked your code very fast and in my Idea everything compile successfully... almost. In class GenerateRandomNumbersSnippetTest change line 67. Line is longer than 100 characters. In checkstyle.xml at line 34 the max line length value equals 100. Line 67 has 102.

iluwatar · 2022-01-12T18:38:35Z

README.md

 ```java
-public static int calculateLuhnChecksum(long num) {
+  public static int calculateLuhnChecksum(long num) {


No need to modify this line

iluwatar · 2022-01-12T18:39:14Z

README.md

+  private static final Random random = new Random();
+
+  public static int generateRandomNumberBetween(int x, int y) {
+    int exclusiveRightBound = y - x + 1;


use var keyword where possible

iluwatar · 2022-01-12T18:43:14Z

src/test/java/math/GenerateRandomNumbersSnippetTest.java

+  @Test
+  void checkThatAllNumbersInTheSpecifiedRangeHaveBeenGenerated() {
+    List<Integer> listOfResults = new ArrayList<Integer>();
+    for (int i = 0; i < 200; i++) {
+      listOfResults.add(GenerateRandomNumbersSnippet.generateRandomNumberBetween(1, 10));
+    }
+    List<Integer> listOfDistinctResults =
+        listOfResults.stream()
+            .distinct()
+            .sorted(Integer::compareTo)
+            .collect(Collectors.toList());
+
+    List<Integer> expectedResult = List.of(1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
+
+    assertEquals(listOfDistinctResults, expectedResult);
+  }


This test looks like it can randomly fail. I'm not sure I understand the purpose of the test either.

iluwatar · 2022-01-12T18:46:14Z

src/main/java/math/GenerateRandomNumbersSnippet.java

+   *
+   * @param numberOfDice represents number of dice being thrown
+   * @param typeOfDice   represents number of sides of the dice
+   * @return random integer between 1 and 6 (inclusive)


Not true, depends on the parameters

iluwatar · 2022-01-12T18:48:06Z

src/test/java/math/GenerateRandomNumbersSnippetTest.java

+  @CsvSource({
+      "1, 6",
+      "2, 6",
+      "3, 6",
+      "1, 10",
+      "2, 10",
+      "10, 6",
+      "10, 10",
+      "20, 5"
+  })


The test data is lacking 0 and negative numbers

PraveenNanda124

Good work

stale · 2022-12-31T17:04:21Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

stale · 2023-02-14T19:53:56Z

Closed due to inactivity. Thank you for your contributions.

iluwatar self-assigned this Oct 30, 2021

iluwatar added the status: under review label Oct 30, 2021

iluwatar requested changes Oct 30, 2021

View reviewed changes

asilenko added 2 commits October 31, 2021 09:11

Add code snippet for Generate random numbers

1a095d3

Add parametrized test

a01d1b1

asilenko force-pushed the 105-generate-random-numbers branch from 15cc998 to a01d1b1 Compare November 6, 2021 15:30

asilenko requested a review from iluwatar November 6, 2021 16:59

iluwatar requested changes Nov 11, 2021

View reviewed changes

asilenko added 2 commits November 13, 2021 07:44

Fix style

e67db72

Correct style and and one new test

e4513ce

asilenko requested a review from iluwatar November 20, 2021 07:41

asilenko added 2 commits November 20, 2021 08:48

Small fix in README.md

ab4c79b

Correct test

76a2a38

iluwatar requested changes Dec 6, 2021

View reviewed changes

Fix checkstyle problem

d894fe0

asilenko requested a review from iluwatar January 8, 2022 22:39

iluwatar requested changes Jan 9, 2022

View reviewed changes

Last try

56614c2

asilenko requested a review from iluwatar January 9, 2022 17:52

Correct too long line in tests

29f107a

iluwatar requested changes Jan 12, 2022

View reviewed changes

PraveenNanda124 reviewed Dec 1, 2022

View reviewed changes

stale bot added the status: stale label Dec 31, 2022

stale bot closed this Feb 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add code snippet for Generate random numbers #116

Add code snippet for Generate random numbers #116

asilenko commented Oct 27, 2021

iluwatar left a comment

iluwatar Oct 30, 2021

asilenko Nov 6, 2021

iluwatar Oct 30, 2021

asilenko Nov 6, 2021

iluwatar Oct 30, 2021

asilenko Nov 6, 2021

asilenko commented Nov 6, 2021

iluwatar left a comment

asilenko commented Nov 20, 2021

iluwatar left a comment

asilenko commented Jan 8, 2022

iluwatar left a comment

iluwatar commented Jan 9, 2022

asilenko commented Jan 9, 2022

grzesiekkedzior commented Jan 9, 2022

iluwatar Jan 12, 2022

iluwatar Jan 12, 2022

iluwatar Jan 12, 2022

iluwatar Jan 12, 2022

iluwatar Jan 12, 2022

PraveenNanda124 left a comment

stale bot commented Dec 31, 2022

stale bot commented Feb 14, 2023

Add code snippet for Generate random numbers #116

Add code snippet for Generate random numbers #116

Conversation

asilenko commented Oct 27, 2021

iluwatar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asilenko commented Nov 6, 2021

iluwatar left a comment

Choose a reason for hiding this comment

asilenko commented Nov 20, 2021

iluwatar left a comment

Choose a reason for hiding this comment

asilenko commented Jan 8, 2022

iluwatar left a comment

Choose a reason for hiding this comment

iluwatar commented Jan 9, 2022

asilenko commented Jan 9, 2022

grzesiekkedzior commented Jan 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PraveenNanda124 left a comment

Choose a reason for hiding this comment

stale bot commented Dec 31, 2022

stale bot commented Feb 14, 2023