added improved Fibonacci sequence number finder with dynamic programming #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iluwatar please review this PR. |
Ritabrata1080
approved these changes
Oct 13, 2024
iluwatar
requested changes
Nov 3, 2024
README.md
Outdated
Comment on lines
1298
to
1315
| /** | ||
| * Fibonacci series using dynamic programming. Works for larger ns as well. | ||
| * | ||
| * @param n given number | ||
| * @return fibonacci number for given n | ||
| */ | ||
| public static int fibonacciBig(int n) { | ||
| int previous = 0; | ||
| int current = 1; | ||
| for (int i = 0; i < n - 1; i++) { | ||
| int t = previous + current; | ||
| previous = current; | ||
| current = t; | ||
| } | ||
|
|
||
| return current; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this is the correct position in the README.md. Check below, there is already another Fibonacci implementation.
Damian-crypto
force-pushed
the
add-improved-fibonacci-dp
branch
from
ac19053 to
92483c3
Compare
|
iluwatar
approved these changes
Nov 10, 2024
|
Looks good! Thank you for the contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a dynamic programming approach to optimize the Fibonacci sequence number finder for improved efficiency.