Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decommission controlled discovery/pr #49

Open
wants to merge 88 commits into
base: decommission/pr
Choose a base branch
from
Open

Decommission controlled discovery/pr #49

wants to merge 88 commits into from

Conversation

imRishN
Copy link
Owner

@imRishN imRishN commented Sep 1, 2022

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 8eb27f0

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: 5602013

gbbafna
gbbafna reviewed Sep 1, 2022
View reviewed changes
server/src/main/java/org/opensearch/cluster/coordination/JoinHelper.java
logger.info("local node is decommissioned. Will not be able to join the cluster");
if (!isDecommissioned) {
isDecommissioned = true;
nodeCommissionedListener.onFailure(exp);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : it doesn't look like a Failure, but an expected behavior. I would prefer just a Executor over ActionListener for same reason .

But overall it looks good.

@imRishN
Add Executor to decommission node attribute
9b864e2 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Add DecommissionHelper
6f188e8 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Decommission service implementation with metadata
c57bc77 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fixes
d348085 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Master abdication
9cccc44 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fixes
4923f0a 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Update join validator to validate decommissioned node join request
38c5930 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Clear voting config after decommissioning
42050fa 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Resolving comments
30dbfdc 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fixes
52a8e6b 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fixes
1561024 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Some refactpring
53057ac 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Updates
5c2b91c 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix to abdication
fc95ac3 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Remove cluster state variable from service
ac9c372 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Log node string
825092a 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix conflict
6a3157c 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Changes in Service
109459b 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix spotless check
4cd06da 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Update the join validator for decommissioned attribute
a28e6fd 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Add UTs for metadata
763f241 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Add UTs for JoinTaskExecutor changes
1464bbb 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix
f3d49a3 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Test files
fd0bbe8 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Move observer logic to helper
efdad78 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
fix msg
48def4b 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
imRishN and others added 7 commits September 13, 2022 20:12
@imRishN
Empty-Commit
a6619b5 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@ankitkala @imRishN
Add getHistoryOperationsFromTranslog method to fetch the history snap…
06048a8 
…shot from translogs (opensearch-project#3948)

* Add getHistoryOperationsFromTranslog method to fetch the hostory snapshot from translogs

Signed-off-by: Ankit Kala <ankikala@amazon.com>
@imRishN
Add package-info and Changelog
3a1dbc8 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Empty-Commit
418c079 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Address Comments
ac28c4d 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix tests
4b37726 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix spotless check
a268fd3 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Update logic for exclusion response
0d420b1 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Update Changelog
84443be 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Addressing minor comments
0bcf6b3 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Update request eligibility check
e114e85 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Update metadata usage
ad9f040 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Remove fromStage method and update withUpdatedStatus method in metadata
7a65770 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix spotless check
453b1b1 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Add observer to ensure abdication
1b42670 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Refactor node removal observer
a30fa9d 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix spotless check
32481f5 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Update state transistions
9f6e1de 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Small fixes
32de492 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fixes
779bdf8 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Fix spotless check
0d81ae2 
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
@imRishN
Control peer discovery during decommission
b8bd931
@imRishN
Change runnable to action listener
828167f
@imRishN
skip prevoting for decommissioned nodes irrespective of cluster state
e73f4f7
@imRishN imRishN force-pushed the decommission-controlled-discovery/pr branch from 5602013 to e73f4f7 Compare September 20, 2022 07:44
@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: e73f4f7

@github-actions
Copy link

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL:
  • CommitID: e55b588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imRishN @gbbafna @ankitkala